Conversation
vlebourl
approved these changes
Aug 6, 2020
Contributor
vlebourl
left a comment
vlebourl
left a comment
There was a problem hiding this comment.
I guess that's enough on the API side. For HA, we need to consider how to classify an entity that doesn't have a uiClass as we map the Somfy widgets and ui_classes to the Home Assistant platforms.
Collaborator
Author
|
@vlebourl That's an edge case, the device returned is marked as "not available". On HA side, we already handle this case. We map the None value... to nothing. We will see if "real" device will come with this behavior. |
iMicknl
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix iMicknl/ha-tahoma#205