Conversation
Owner
iMicknl
commented
Jul 17, 2020
iMicknl
commented
- Reuse session
- Abstract login method
- Add first exception logic
tetienne
approved these changes
Jul 17, 2020
| [tool.poetry.dependencies] | ||
| python = ">=3.6" | ||
| aiohttp = "^3.6.2" | ||
| aiohttp = "3.6.1" |
Collaborator
There was a problem hiding this comment.
Why downgrade the version?
Owner
Author
There was a problem hiding this comment.
Currently I am loading the integration in ha-tahoma via manifest.json. In development, this conflicts with the built-in version of aihttp in HA. I downgraded it temporarily for development.
"requirements": [
"git+https://github.com/iMicknl/python-tahoma-api.git@enhancement/reuse_session#tahoma_api===0.1.0"
],
|
|
||
| return response | ||
|
|
||
| async def __do_http_request( |
Collaborator
There was a problem hiding this comment.
In a future PR, it would be nice to create dedicated get and post methods.
Owner
Author
There was a problem hiding this comment.
@tetienne agree, I am not a fan of this huge method yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.