Skip to content

fix(channel): pass model via extra for non-aionrs conversations#298

Merged
piorpua merged 1 commit into
mainfrom
fix/channel-model-placement
May 19, 2026
Merged

fix(channel): pass model via extra for non-aionrs conversations#298
piorpua merged 1 commit into
mainfrom
fix/channel-model-placement

Conversation

@piorpua
Copy link
Copy Markdown
Contributor

@piorpua piorpua commented May 19, 2026

Summary

  • Channel message service was unconditionally placing model at the top level of CreateConversationRequest, but the conversation service rejects top-level model for non-aionrs agent types (acp, openclaw-gateway, nanobot, remote) with a 400 error.
  • Now only aionrs keeps model at the top level; all other agent types pass it through extra["model"].
  • Added regression tests to prevent this from breaking again when conversation validation rules change.

Test plan

  • cargo clippy -p aionui-channel -- -D warnings passes
  • cargo test -p aionui-channel --lib — 204 tests pass
  • just push passes (fmt + clippy + full test suite)
  • Verify Telegram/Lark channel conversations work end-to-end with acp agent type
  • Verify aionrs channel conversations still work with top-level model

The conversation service rejects top-level `model` for non-aionrs
agent types (acp, openclaw-gateway, nanobot, remote). Channel message
service was unconditionally placing model at the top level, causing
all non-aionrs channel conversations to fail with a 400 error.

Now aionrs keeps model at the top level while all other types pass it
through `extra["model"]`.
@piorpua piorpua enabled auto-merge (squash) May 19, 2026 06:10
@piorpua piorpua merged commit eb65dfe into main May 19, 2026
5 checks passed
@piorpua piorpua deleted the fix/channel-model-placement branch May 19, 2026 06:19
piorpua pushed a commit that referenced this pull request May 19, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.5](v0.1.4...v0.1.5)
(2026-05-19)


### Features

* **ai-agent:** add cc-switch provider env injection for Claude ACP
([#291](#291))
([a7b93e7](a7b93e7))


### Bug Fixes

* **channel:** pass model via extra for non-aionrs conversations
([#298](#298))
([eb65dfe](eb65dfe))


### Code Refactoring

* rename binary from aioncli to aioncore
([#293](#293))
([ae78cd1](ae78cd1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant