fix(runtime): create node symlink in bundled bun directory (ELECTRON-1EY)#310
Merged
Conversation
…1EY) Users without a standalone Node.js installation cannot use Claude Code agent because `@agentclientprotocol/claude-agent-acp` (or its transitive deps) contains scripts with `#!/usr/bin/env node` shebangs. When the bundled bun directory is on PATH but has no `node` entry, `env` fails with "No such file or directory" and the agent process exits 127 before the ACP handshake completes. Create a `node` symlink (Unix) / copy (Windows) pointing to the bundled `bun` binary during extraction. Since bun is a Node-compatible runtime, shebang-based invocations resolve correctly without requiring a system Node installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodesymlink (Unix) / copy (Windows) pointing to the bundledbunbinary during runtime extraction#!/usr/bin/env nodeshebangs in npm packages resolve correctly even when no standalone Node.js is installed on the hostRoot Cause
The v2.0.5 architecture migrated agent spawning from the frontend (which used Electron's built-in Node.js) to the backend (aioncore), which uses the bundled bun runtime to execute
bun x @agentclientprotocol/claude-agent-acp. That package contains scripts with#!/usr/bin/env nodeshebangs. On hosts without a system Node.js installation,envcannot findnode, the process exits with code 127, and the ACP handshake never completes (502 Bad Gateway).Since bun is a fully Node-compatible runtime, adding a
node→bunsymlink in the bundled runtime directory (which is already at the front of PATH) resolves the issue without requiring users to install Node.js.Test plan
extract_happy_path_creates_bun_and_bunx_and_nodeverifies the symlink is created