Non-Threadsafe Perl5Compiler used as static instance in RegExpMatch

[sLite]

RegExpMatch uses a static instance of Perl5Compiler, while the JavaDoc of Perl5Compiler states that it's not threadsafe.

We are getting random errors (invalid patterns, array index out of bounds, ...) from independent expect4java instances in different threads.
Further investigation led me down the road to the JavaDoc of Perl5Compiler and the static instance of it in RegExpMatch.java.

Best Regards
Daniel

[sLite]

Worked around like this for now:

    /**
     * Synchronized helper method to workaround https://github.com/iTransformers/expect4java/issues/1
     */
    @Nonnull
    private static synchronized RegExpMatch regexp(@Nonnull final String prompt) throws MalformedPatternException {
        return regexp(prompt, null);
    }

    /**
     * Synchronized helper methods to workaround https://github.com/iTransformers/expect4java/issues/1
     */
    @Nonnull
    private static synchronized RegExpMatch regexp(@Nonnull final String prompt, @Nullable final Closure closure) throws MalformedPatternException {
        return new RegExpMatch(prompt, closure);
    }

[vasil-yordanov]

Hello I will take a look today. Regards, Vasil

…

On Sat, 28 Mar 2020, 15:27 sLite, ***@***.***> wrote: Worked around like this for now: /** * Synchronized helper method to workaround #1 */ @nonnull private static synchronized RegExpMatch ***@***.*** final String prompt) throws MalformedPatternException { return regexp(prompt, null); } /** * Synchronized helper methods to workaround #1 */ @nonnull private static synchronized RegExpMatch ***@***.*** final String prompt, @nullable final Closure closure) throws MalformedPatternException { return new RegExpMatch(prompt, closure); } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIG7N7PAY3Q4DAKR3G75ODRJX3L5ANCNFSM4LUTHCQQ> .

[vasil-yordanov]

Hello, Thanks for your contribution, If you find any other issue, please let me know. Or just make a merge request I pushed the changes, now trying to release in maven artifactory. Regards, Vasil <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon> Virus-free. www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> On Sat, Mar 28, 2020 at 3:56 PM Vasil Yordanov <vasil.yordanov@gmail.com> wrote:

…

Hello I will take a look today. Regards, Vasil On Sat, 28 Mar 2020, 15:27 sLite, ***@***.***> wrote: > Worked around like this for now: > > /** > * Synchronized helper method to workaround #1 > */ > @nonnull > private static synchronized RegExpMatch ***@***.*** final String prompt) throws MalformedPatternException { > return regexp(prompt, null); > } > > /** > * Synchronized helper methods to workaround #1 > */ > @nonnull > private static synchronized RegExpMatch ***@***.*** final String prompt, @nullable final Closure closure) throws MalformedPatternException { > return new RegExpMatch(prompt, closure); > } > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#1 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAIG7N7PAY3Q4DAKR3G75ODRJX3L5ANCNFSM4LUTHCQQ> > . >