Skip to content

Updated imodel-browser-react to itwinui-react 3.x#144

Merged
nimam-bentley merged 18 commits intomainfrom
DanishM/browserv3
Apr 9, 2025
Merged

Updated imodel-browser-react to itwinui-react 3.x#144
nimam-bentley merged 18 commits intomainfrom
DanishM/browserv3

Conversation

@DanishMehmood-bit
Copy link
Copy Markdown
Contributor

@DanishMehmood-bit DanishMehmood-bit commented Mar 21, 2025

Closes workitem

Updated only imodel-browser-react to itwinui-react 3.x

@DanishMehmood-bit DanishMehmood-bit marked this pull request as ready for review March 21, 2025 16:38
Copy link
Copy Markdown
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have 3 PRs for updating to iTwinUI

Granted the other two also cover updating the entire monorepo at once which is uneeded. Some of the comments in the other two do bring up good points regarding how to migrate to iTwinUI v3.

Comment thread packages/modules/imodel-browser/package.json Outdated
Comment thread packages/modules/imodel-browser/package.json Outdated
Comment thread packages/modules/imodel-browser/package.json Outdated
@aruniverse aruniverse mentioned this pull request Apr 1, 2025
Comment thread packages/apps/storybook/package.json
Comment thread packages/apps/storybook/package.json Outdated
Comment thread packages/modules/imodel-browser/src/containers/iModelTiles/IModelTile.scss Outdated
Comment thread packages/apps/storybook/package.json Outdated
Comment thread packages/modules/imodel-browser/src/containers/iModelTiles/IModelTile.scss Outdated
Comment thread packages/apps/storybook/.storybook/preview.js
@nimam-bentley
Copy link
Copy Markdown
Contributor

merged/overwrote imodel-browser-react changes from 141

Comment thread packages/modules/imodel-browser/package.json Outdated
Comment thread packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinTile.tsx Outdated
@aruniverse
Copy link
Copy Markdown
Member

Have you guys ran the storybook? I'm running it now to verify, and things seem broken or not working at all

image

image

image

image

@DanishMehmood-bit
Copy link
Copy Markdown
Contributor Author

DanishMehmood-bit commented Apr 9, 2025

Have you guys ran the storybook? I'm running it now to verify, and things seem broken or not working at all

image

image

image

image

We should remove this TileWrappers as its not needed right now. Adding more stuff to this PR will only delay its merge

@nimam-bentley
Copy link
Copy Markdown
Contributor

Have you guys ran the storybook? I'm running it now to verify, and things seem broken or not working at all

image

image

image

image

adjusted
Screenshot 2025-04-09 at 2 16 10 PM
Screenshot 2025-04-09 at 2 16 27 PM
Screenshot 2025-04-09 at 2 17 07 PM

…025-04-01-13-57.json

Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
Copy link
Copy Markdown
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nimam-bentley , ran the storybook and lgtm

@nimam-bentley nimam-bentley merged commit 073e5d6 into main Apr 9, 2025
4 checks passed
@nimam-bentley nimam-bentley deleted the DanishM/browserv3 branch April 9, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants