Skip to content

Fixed imodel populate calling imodel connection auth when not appropriate and not checking for errors.#139

Merged
Nadegamra merged 8 commits intomainfrom
nadegamra/imodel-populate-fix
May 15, 2025
Merged

Fixed imodel populate calling imodel connection auth when not appropriate and not checking for errors.#139
Nadegamra merged 8 commits intomainfrom
nadegamra/imodel-populate-fix

Conversation

@Nadegamra
Copy link
Collaborator

  • Fixed imodel connection auth command being using with a Service client (It is only supposed to be used with User authentication).
  • Added error detection for the case when synchronization run completes unsuccessfully in imodel populate command.
  • Added a few new tests for imodel populate command.
  • Replaced "Debug Active Test" launch configuration with 2 different configurations for each client type.
  • Moved client-specific setups and notifications about the currently used client to integration-tests/utils/mocha-global-setup-*.ts.

Nadegamra added 2 commits May 14, 2025 09:50
…ice client. Moved out setup for running tests with a specific client to utils/mocha-global-setup-*.ts. Added seperate launch configurations for launching active test with a specific client.
…sts for imodel populate command. Moved current used client notification to integration-tests/utils/mocha-global-setup-*.ts. A few misc fixes.
@Nadegamra Nadegamra changed the title Nadegamra/imodel populate fix Fixed imodel populate calling imodel connection auth when not appropriate and not checking for errors. May 14, 2025
@Nadegamra Nadegamra merged commit 1bbd281 into main May 15, 2025
13 checks passed
@Nadegamra Nadegamra deleted the nadegamra/imodel-populate-fix branch May 15, 2025 06:28
linasburneika pushed a commit that referenced this pull request Aug 19, 2025
…ropriate and not checking for errors. (#139)

* Fixed imodel:connection:auth being called in populate when using service client. Moved out setup for running tests with a specific client to utils/mocha-global-setup-*.ts. Added seperate launch configurations for launching active test with a specific client.

* Added a check for failures to imodel populate command. Added a few tests for imodel populate command. Moved current used client notification to integration-tests/utils/mocha-global-setup-*.ts. A few misc fixes.

* Increased default test timeout to 2min.

* Removed tests skips from imodel populate tests. Added some debug logging to named-version.ts before() hook.

* Debug changes.

* Debug changes.

* Fixed a few issues in tests.

* Updated a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants