Add alternatives to JSON flags where possible #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' and 'imodel connection sourcefile add' commands. Added a check to 'imodel populate' for the case when connector-type count is not equal to file count or 1.
…ember group add' command. Added JSON validation for commands, that accept JSON.
…ember group add command.
…member user add' command.
… in order to avoid errors.
Collaborator
|
https://blog.kellybrazil.com/2022/05/19/working-with-json-in-various-shells/ Traditional shells like Bash and Windows Command Prompt (cmd.exe) don’t have built-in JSON support and require 3rd party utilities. Newer shells like NGS, Nushell, Oil, Elvish, Murex, and PowerShell have JSON serialization/deserialization and filtering capabilities built-in for a cleaner experience. It's not in scope of this PR, but we need to document and provide guidelines how to pass over json data through CLI commands in the most popular shells: cmd, bash, pwsh |
Collaborator
|
There is a general issue across all the files that |
linasburneika
previously approved these changes
May 22, 2025
…sallow providing multiple.
linasburneika
previously approved these changes
May 27, 2025
linasburneika
approved these changes
May 27, 2025
linasburneika
pushed a commit
that referenced
this pull request
Aug 19, 2025
* Added alternative extent flags to imodel create command. * Added alternative extent flags to imodel update command. * Fixed connector-type options being different between 'imodel populate' and 'imodel connection sourcefile add' commands. Added a check to 'imodel populate' for the case when connector-type count is not equal to file count or 1. * Added alternative flags for '--groups' JSON flag in 'access-control member group add' command. Added JSON validation for commands, that accept JSON. * Added GUID CSV list validation to --role-ids flag in �ccess-control member group add command. * Added alternative flags for '--members' JSON flag in 'access-control member user add' command. * Re-generated documentation. * Updated docs-generator command, so it always runs npm build before it in order to avoid errors. * Changed endlines in some command descriptions. * Addressed part of PR comments. * Addressed PR comment. * Updated documentation. * Removed JSON validation. Will re-add it in a separate PR. * Updated examples for 'access-control member group add' command. * Updated 'access-control member group add' command role-ids flag to disallow providing multiple. * Updated documentation. * Updated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access-control member group add---group-idand--role-idsas an alternative to--groupsaccess-control member user add---emailand--role-idsas an alternative to--membersimodel create---sw-latitude,--sw-longitude,--ne-latitude,--ne-longitudeas an alternative to--extentimodel update---sw-latitude,--sw-longitude,--ne-latitude,--ne-longitudeas an alternative to--extentimodel populatecommand now returns an error if--connector-typecount is not equal--filecount and is not 1.imodel populateandimodel connection sourcefile addcommands