Skip to content

Updated itp context set command to not use existing context.#155

Merged
Nadegamra merged 1 commit intomainfrom
nadegamra/context-set-fix
May 27, 2025
Merged

Updated itp context set command to not use existing context.#155
Nadegamra merged 1 commit intomainfrom
nadegamra/context-set-fix

Conversation

@Nadegamra
Copy link
Collaborator

@Nadegamra Nadegamra commented May 22, 2025

  • This fixes an issue, where imodel-id from context is passed to context set command, when it is not provided directly to the command.

@linasburneika
Copy link
Collaborator

The cli context is convenient, but writing context data to file means it's shared across all instance of CLI in the same machine.
That can be undesirable for concurrent automation jobs, which could easily overwrite each other context.

I think the default should be to write it to env variables of shell process. Persisting it to file can be an option for humans

@Nadegamra Nadegamra requested a review from linasburneika May 27, 2025 06:09
@Nadegamra Nadegamra merged commit 5ae1be4 into main May 27, 2025
13 checks passed
@Nadegamra Nadegamra deleted the nadegamra/context-set-fix branch May 27, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants