Conversation
Collaborator
Nadegamra
commented
Jun 18, 2025
Nadegamra
commented
- Added a custom flag type for emails.
- Moved float and uuidCsv validation into custom flag types.
… Added integration tests for testing email flags.
linasburneika
approved these changes
Jun 18, 2025
linasburneika
pushed a commit
that referenced
this pull request
Aug 19, 2025
* Moved float validation to a seperate flag type. * Moved uuidCsv validation to a new flag type. Added email custom flag. Added integration tests for testing email flags. * Removed validateFloat export from custom-flags/float.ts. * Updated float custom flag to return a number instead of a string. * Added expected format to float custom flag error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.