Conversation
🦋 Changeset detectedLatest commit: 04eb326 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Unified selection benchmark
| Benchmark suite | Current: 04eb326 | Previous: e8319ab | Deviation | Status |
|---|---|---|---|---|
hilite 50k elements |
1349.24 ms |
1304.77 ms |
3.41% |
〰️ |
hilite 50k elements (P95 of main thread blocks) |
50 ms |
49 ms |
2.04% |
〰️ |
hilite 50k group elements |
238.97 ms |
238.96 ms |
0.00% |
〰️ |
hilite 50k group elements (P95 of main thread blocks) |
31 ms |
31 ms |
0% |
🟰 |
hilite 1k subjects |
44449.19 ms |
47097.19 ms |
-5.62% |
〰️ |
hilite 1k subjects (P95 of main thread blocks) |
25 ms |
28 ms |
-10.71% |
〰️ |
hilite 50k subcategories |
280.54 ms |
287.55 ms |
-2.44% |
〰️ |
hilite 50k subcategories (P95 of main thread blocks) |
34 ms |
34 ms |
0% |
🟰 |
hilite 50k functional 3D elements |
28004.54 ms |
28592.04 ms |
-2.05% |
〰️ |
hilite 50k functional 3D elements (P95 of main thread blocks) |
41 ms |
40 ms |
2.50% |
〰️ |
hilite 50k functional 2D elements |
6558.48 ms |
6414.74 ms |
2.24% |
〰️ |
hilite 50k functional 2D elements (P95 of main thread blocks) |
43 ms |
47 ms |
-8.51% |
〰️ |
compute selection for 50k elements |
332.94 ms |
313.01 ms |
6.37% |
〰️ |
compute selection for 50k elements (P95 of main thread blocks) |
36 ms |
31 ms |
16.13% |
〰️ |
compute parent selection for 50k elements |
333.64 ms |
378.39 ms |
-11.83% |
〰️ |
compute parent selection for 50k elements (P95 of main thread blocks) |
31 ms |
39 ms |
-20.51% |
〰️ |
compute top ancestor selection for 50k elements |
563.5 ms |
572.81 ms |
-1.63% |
〰️ |
compute top ancestor selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute category selection for 50k elements |
93.93 ms |
93.56 ms |
0.40% |
〰️ |
compute category selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute model selection for 50k elements |
74.56 ms |
72.72 ms |
2.53% |
〰️ |
compute model selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 3D elements |
380.32 ms |
417.85 ms |
-8.98% |
〰️ |
compute functional selection for 50k 3D elements (P95 of main thread blocks) |
33 ms |
38 ms |
-13.16% |
〰️ |
compute parent functional selection for 50k 3D elements |
426.73 ms |
423.85 ms |
0.68% |
〰️ |
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) |
32 ms |
32 ms |
0% |
🟰 |
compute top ancestor functional selection for 50k 3D elements |
1169.16 ms |
1168.67 ms |
0.04% |
〰️ |
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 2D elements |
2838.66 ms |
2992.59 ms |
-5.14% |
〰️ |
compute functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute parent functional selection for 50k 2D elements |
2850.03 ms |
2955.93 ms |
-3.58% |
〰️ |
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute top ancestor functional selection for 50k 2D elements |
3016.57 ms |
2912.69 ms |
3.57% |
〰️ |
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull request overview
This PR bumps several workspace dependency versions (primarily via pnpm catalogs) to reduce reported security vulnerabilities across the monorepo.
Changes:
- Update multiple
@itwin/*catalog versions (appui + itwinjs core/dev) and a few build-tool versions inpnpm-workspace.yaml. - Bump
@changesets/cliin the repo root. - Bump a handful of direct dependencies in app workspaces (
fast-xml-parser,sass,@types/brotli) and add a changeset to publish patch releases.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-workspace.yaml |
Bumps shared catalog versions used across many workspaces. |
package.json |
Updates root dependency on @changesets/cli. |
apps/test-app/frontend/package.json |
Updates fast-xml-parser and sass versions. |
apps/load-tests/tests/package.json |
Updates @types/brotli version. |
apps/full-stack-tests/package.json |
Updates fast-xml-parser version. |
.changeset/huge-islands-stick.md |
Adds a patch changeset to release affected packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Hierarchies benchmark
| Benchmark suite | Current: 04eb326 | Previous: e8319ab | Deviation | Status |
|---|---|---|---|---|
flat 50k elements list |
4513.48 ms |
4542.01 ms |
-0.63% |
〰️ |
flat 50k elements list (P95 of main thread blocks) |
71 ms |
68 ms |
4.41% |
〰️ |
filtering filters with 50000 paths |
8660.81 ms |
8899.82 ms |
-2.69% |
〰️ |
filtering filters with 50000 paths (P95 of main thread blocks) |
124 ms |
126 ms |
-1.59% |
〰️ |
grouping by label |
9703.36 ms |
9850.07 ms |
-1.49% |
〰️ |
grouping by label (P95 of main thread blocks) |
52 ms |
52 ms |
0% |
🟰 |
grouping by class |
9700.89 ms |
9870.8 ms |
-1.72% |
〰️ |
grouping by class (P95 of main thread blocks) |
44 ms |
39 ms |
12.82% |
〰️ |
grouping by property |
10389.19 ms |
10389.21 ms |
-0.00% |
〰️ |
grouping by property (P95 of main thread blocks) |
54 ms |
44 ms |
22.73% |
〰️ |
grouping by base class (10 classes) |
7575.18 ms |
7601.8 ms |
-0.35% |
〰️ |
grouping by base class (10 classes) (P95 of main thread blocks) |
71 ms |
69 ms |
2.90% |
〰️ |
grouping by multiple attributes |
25743.99 ms |
27008.75 ms |
-4.68% |
〰️ |
grouping by multiple attributes (P95 of main thread blocks) |
51 ms |
46 ms |
10.87% |
〰️ |
hide if no children required to finalize root, w/o children |
40623.58 ms |
42909.75 ms |
-5.33% |
〰️ |
hide if no children required to finalize root, w/o children (P95 of main thread blocks) |
36 ms |
37 ms |
-2.70% |
〰️ |
hide if no children required to finalize root, w/ children |
160.21 ms |
164.63 ms |
-2.68% |
〰️ |
hide if no children required to finalize root, w/ children (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree initial (Baytown) |
39.39 ms |
41.66 ms |
-5.45% |
〰️ |
models tree initial (Baytown) (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree full (Baytown) |
6448.48 ms |
6675.46 ms |
-3.40% |
〰️ |
models tree full (Baytown) (P95 of main thread blocks) |
83 ms |
91 ms |
-8.79% |
〰️ |
models tree creates initial filtered view for 50k target items |
2279.2 ms |
2245.6 ms |
1.50% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
333 ms |
67 ms |
397.01% |
🚨 |
This comment was automatically generated by workflow using github-action-benchmark.
before:
after:
mochais the culprit of the 2 issues that are left.