This repository was archived by the owner on Jan 15, 2026. It is now read-only.
Save json files with UIViewController memory leak name#98
Merged
bartszczepaniak merged 2 commits intomasterfrom Feb 22, 2024
Merged
Conversation
Storing memory leak `UIViewController` name each time we encounter one. This can be extracted from `/tmp/presentation-memory-leaks/` directory.
bartszczepaniak
force-pushed
the
experiment-saving-vc-memory-leaks-into-json-files
branch
from
13be9ad to
7a3a72e
Compare
|
|
||
| func onLeak() { | ||
| log(.didLeak(.init(vcPresentationDescription), from: .init(presentationDescription))) | ||
| let memoryLeak = UIVCMemoryLeak(name: self.presentationTitle) |
Collaborator
There was a problem hiding this comment.
So as I understand we store the title of controller where the leak had occurred. But how we going to use that data?
Collaborator
Author
There was a problem hiding this comment.
Once we got stored files with names of view controllers after running UI tests we can process it at the end on CI.
shchukin-alex
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing memory leak
UIViewControllername each time we encounter one.This can be extracted from
/tmp/presentation-memory-leaks/directory.