fix(issues): correct command parameter types for codegen#5
Merged
Conversation
This was referenced Feb 4, 2026
fcc9b38 to
7fa3090
Compare
Pass QuerySearchIssuesArgs fields directly instead of wrong type. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Ensure parameters match IssueUpdateInput type from codegen. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
62e3871 to
489d51e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the issues command layer to work correctly with the codegen types introduced in the service layer (PR #4). It's a small but critical fix that ensures the command-line interface properly passes parameters to the refactored service methods.
What Changed
Search Command
Before:
After:
Fixed parameter structure to match the updated service method signature.
Update Command
Before:
After:
Simplified parameter handling to align with codegen mutation input types.
Why This Matters
Type Safety at the Command Layer
CLI tools have two critical boundaries where type safety matters:
This PR ensures the second boundary is type-safe. The compiler now verifies:
Better Error Messages
When users make mistakes, TypeScript can now provide precise errors:
Before:
After:
The error points to the exact parameter issue rather than failing deep in the service layer.
Impact on Users
Users see:
Impact on Contributors
Contributors benefit from:
Technical Details
Parameter Type Fixes
IssueUpdateInputfrom codegenNo Breaking Changes
Command-line interface is unchanged:
Users experience no difference in behavior.
Why Two Separate PRs?
PR #4 refactored the service layer, but kept command layer compatibility temporarily. This PR completes the migration by updating commands to use the new service signatures properly.
Splitting the work allows:
Stack Position
📍 Branch 4 of 7 - Base:
3-issues-service-codegen⬇️ Previous: PR #4 - Refactor Issues Service to Use Codegen Types
⬆️ Next: PR #6 - Migrate Documents and Attachments Services to Codegen Types
🤖 Generated with Claude Code