Skip to content

Conversation

@hazemmadkour
Copy link

i have added new localization file for ar-eg and also support meradien translation in arabic

@VehpuS
Copy link
Contributor

VehpuS commented Dec 21, 2020

Probably worth checking if this makes this obsolete (or if the comments there apply to this changes): #943

@hazemmadkour
Copy link
Author

it is related hopefully its soon merged and fix. thank you

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #1283 (6c0a69b) into dev (0e7ff3d) will decrease coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev    #1283      +/-   ##
===========================================
- Coverage   100.00%   99.88%   -0.12%     
===========================================
  Files          174      175       +1     
  Lines         1669     1675       +6     
  Branches       381      383       +2     
===========================================
+ Hits          1669     1673       +4     
- Misses           0        1       +1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
src/locale/ar-eg.js 60.00% <60.00%> (ø)
src/locale/ar.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7ff3d...6c0a69b. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Dec 25, 2020

Please make the CI passed. Also any relation between ar and ar-eg, pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants