fix: do not modify dayjs input arguments #1529
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when passing in an array of date formats:
"If you don't know the exact format of an input string, but know it could be one of many, you can use an array of formats."
(from https://day.js.org/docs/en/parse/string-format) it was actually modifying the input array. This seems pretty bad.
I'm not sure if your build supports the ... syntax. It could be changed to Object.assign or similar if you want.