dayjs 2.0 - plugin WeekOfYear - based on pr 2050 #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests from ArraySupport in dayjs v1.x
Prior to using 'vi.setSystemTime(now)' the mocking of the timers must be activated with 'vi.useFakeTimers()'
Differentiating between 'date' and 'day' is not very easy.
… set Units for add / sub / diff / get / set are modifications of the units for parsing / formatting and are used in several places. Therefore type definitions for these derived types are added.
BREAKING CHANGE: in dayjs 1.0: only days and weeks are rounded to the nearest integer. In moment: days and months are rounded to the nearest integer; Weeks, quarters, and years are converted to days or months, and then rounded to the nearest integer. Negative numbers are rounded as positive numbers with the sign added to the result.
An array with only a year value (first element) returned "invalid Date"; in this case the correct date is returned, only if the second parameter is not undefined (but e.g. null)
Example for offset not full or halve hours is '1879-12-31' for timezone 'Europe/Berlin', where utcOffset is '00:53'. Solves issue iamkun#1996.
The type 'GetterFn' is needed by plugins that add getter / setter to Dayjs.
Change name of parameter with value to add / subtract from the quite generic 'number' to 'value' to avoid get consistent with the parameter names e.g. of 'set'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the plugin WeekOfYear for dayjs 2.0. This pr is based on pr #2050.
See question in issue #2052 about the recommended style of the plugin. So in case given I have to change the implementation so that it puts all the functionality of 'week' into the plugin that is now in the dayjs core module.