Skip to content

fix: handle invalid duration humanize#3024

Open
DeoJin wants to merge 1 commit intoiamkun:devfrom
DeoJin:fix/issue-3006
Open

fix: handle invalid duration humanize#3024
DeoJin wants to merge 1 commit intoiamkun:devfrom
DeoJin:fix/issue-3006

Conversation

@DeoJin
Copy link
Copy Markdown

@DeoJin DeoJin commented Mar 18, 2026

Summary

Return \invalid duration\ from \duration.humanize()\ when the duration value is not finite, instead of letting relative-time formatting turn \NaN\ into an incorrect humanized string.

Changes

  • guard \Duration#humanize\ against non-finite millisecond values
  • add regression coverage for \dayjs.duration(NaN).humanize()\ with and without suffixes

Testing


  • px jest test/plugin/duration.test.js --runInBand\

Fixes #3006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duration.humanize(): returns "a month" for NaN

1 participant