Fix infinite loop in processing graph conditional routing#22
Merged
Fix infinite loop in processing graph conditional routing#22
Conversation
Merged
Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
…ion limit configurable Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
…ng conversion Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update stacked PR to address feedback from PR #21
Fix infinite loop in processing graph conditional routing
Dec 30, 2025
iamtekson
reviewed
Dec 30, 2025
Owner
iamtekson
left a comment
There was a problem hiding this comment.
looks good. Please fix my comment on this PR.
| # Constants | ||
| # ───────────────────────────────────────────────────────────────────────────── | ||
| # Maximum number of graph iterations to prevent infinite loops | ||
| MAX_TOOL_ITERATIONS = 10 |
Owner
There was a problem hiding this comment.
move this block to the config -> settings.py file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processing graph had conflicting edge definitions that could cause infinite loops when tools are unavailable or fail. The conditional routing from
llmnode was overridden by an unconditional edge, and there was no protection against repeated tool invocations.Graph structure fix
llm → ENDedge that overrode conditional routing logicllm → tools(if requested) orllm → ENDLoop prevention
MAX_TOOL_ITERATIONS = 10constant as recursion limit in graph compilationllm → tools → llmcyclesTool error handling
tool_nodenow handles missing tools gracefully via.get()instead of direct dict accessThese changes allow the graph to terminate gracefully even when processing-specific tools are disabled in
tools/__init__.py.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.