Fix Qt threading violation in MainThreadRunner initialization#41
Merged
Fix Qt threading violation in MainThreadRunner initialization#41
Conversation
Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
Co-authored-by: iamtekson <39838116+iamtekson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on illegal threading issue resolution
Fix Qt threading violation in MainThreadRunner initialization
Jan 5, 2026
iamtekson
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MainThreadRunneris aQObjectthat was being instantiated in__init__(), which may execute on any thread. Qt objects must be created on the thread where they will live to avoid threading violations.Changes:
MainThreadRunnerinstantiation from__init__()toinitGui(), which QGIS guarantees runs on the main threadself.main_runner = Nonein__init__()run()with warning log ifinitGui()was not called properlycanvas_refresh.pyreferencing old initialization locationBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.