Add Letter Triangles game with seeded generation and tests#293
Open
ianfhunter wants to merge 8 commits intomainfrom
Open
Add Letter Triangles game with seeded generation and tests#293ianfhunter wants to merge 8 commits intomainfrom
ianfhunter wants to merge 8 commits intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SeedDisplay,GiveUpButton,GameResult).Description
src/pages/LetterTriangles/LetterTriangles.jsxwith supporting stylesheetLetterTriangles.module.cssandREADME.mddocumenting rules.src/pages/LetterTriangles/letterTrianglesLogic.jswith a seeded backtracking search over dictionary word pools and a deterministic fallback layout when dictionary matching fails.src/packs/word-games/manifest.jsandsrc/App.jsx, and added an SVG icon assetsrc/assets/icons/letter-triangles.svg.src/i18n/locales/en.json,src/i18n/locales/es.json) and a Vitest test filesrc/pages/LetterTriangles/LetterTriangles.test.jsvalidating determinism, length invariants, line reconstruction, and solved-state detection.Testing
npm run test:run -- src/pages/LetterTriangles/LetterTriangles.test.jsand the new generator/tests passed (4 testsall green).npm run test:run -- src/tests/gameReadmeCheck.test.jsandnpm run test:run -- src/tests/gameModuleImports.test.js, both of which passed to confirm README presence and module importability.npm run lintwhich surfaced many pre-existing repo lint errors unrelated to this change, so lint is noted but not blocking this PR.Codex Task