Skip to content

feat: Use 1-based indexing#84

Merged
ianlewis merged 1 commit intomainfrom
81-use-1-based-indexing
Feb 19, 2025
Merged

feat: Use 1-based indexing#84
ianlewis merged 1 commit intomainfrom
81-use-1-based-indexing

Conversation

@ianlewis
Copy link
Copy Markdown
Owner

@ianlewis ianlewis commented Feb 19, 2025

Description:

Use one-based indexing for the line and column of lexemes as this is more user friendly (e.g. for error messages) and more intuitive.

Related Issues:

Fixes #81

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.

Signed-off-by: Ian Lewis <ian@ianlewis.org>
@ianlewis ianlewis linked an issue Feb 19, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (d7e80c4) to head (2029aab).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   91.14%   91.57%   +0.43%     
==========================================
  Files           3        3              
  Lines         463      463              
==========================================
+ Hits          422      424       +2     
+ Misses         30       28       -2     
  Partials       11       11              
Files with missing lines Coverage Δ
lexer.go 86.49% <100.00%> (+0.84%) ⬆️

@ianlewis ianlewis merged commit 5781e00 into main Feb 19, 2025
39 checks passed
@ianlewis ianlewis deleted the 81-use-1-based-indexing branch October 10, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use 1-based indexing

2 participants