Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 91.48% 89.54% -1.95%
==========================================
Files 3 3
Lines 470 373 -97
==========================================
- Hits 430 334 -96
+ Misses 30 28 -2
- Partials 10 11 +1
|
aa34794 to
6c000b5
Compare
Signed-off-by: Ian Lewis <ian@ianlewis.org>
6c000b5 to
70a101c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactors the lexparse API.
lexparse
LexParsenow accepts aLexerandParseras parameters instead of the initial states. Both the lexer and parser are run in their own goroutines.lexer
StatetoLexStateStateFntoLexStateFnLexerno longer creates a goroutine. Callers are now responsible for any necessary goroutines.chan *LexemetoNewLexerandNewParserallowing the caller more control over the lexeme channel.parser
ParseStatetype to represent parser state.ParseStateFnto easily convert a state function into aParseState.Parserinternal state is now protected by async.MutexNode.Left,Node.SetLeft,Node.Right,Node.SetRight,Parser.RotateLeft,Parser.RotateRight.Related Issues:
Fixes #69
Checklist: