Make CodexModules inherit from EnvironmentRedirect#2
Merged
ianmacdougald merged 1 commit intomainfrom Mar 3, 2023
Merged
Conversation
interstitial work I think I did it Clean it up Really, really, I did it this time Initialize CodexObjects within CodexModules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is a pretty big update -- not because it breaks things but because, without doing so, it seriously extends the flexibility of Codex module configurations.
Specifically, with this change, multiple SynthDef objects can be defined within a single script and still be handled correctly by Codex (i.e. by being dynamically tagged and added to the server).
This was achieved by changing the inheritance of CodexModules from Environment to Environment redirect.
I also significantly reduced the number of times CodexObject accesses the CodexModules (now) pseudo-environment when unwrapping the object it stores.