Some small fixes#2
Merged
ianmacl merged 7 commits intoianmacl:masterfrom Oct 13, 2011
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
Not shure if this is required
Owner
There was a problem hiding this comment.
The $app variable can go, but populateState should still be called in case something important is added to the parent class implementation.
Can you just remove the one line instead of commenting it out?
Owner
|
Looks good. One small change as noted and I'll merge it. Thanks! |
Contributor
Author
|
Fixed. |
|
Merged. Thanks! |
elkuku
pushed a commit
to elkuku/patchtester
that referenced
this pull request
Dec 2, 2014
Add a video tutorial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes regarding an error when deleting files, no backup is created, adding colors to error messages ;), and language files.
Still can not fix the issue with the CA - BTW.. I am not on windows ;)