CC-61: <Dialog/> fullWidth Overrides maxWidth

[ianpaschal]

Fixes CC-61

Summary by CodeRabbit

• Bug Fixes
  • Improved dialog sizing behavior for full-height and full-width display modes to ensure proper layout rendering.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0a3ce9df-5472-42c6-90c3-26ebb2624c74

📥 Commits

Reviewing files that changed from the base of the PR and between 42f234c and 09c48d0.

📒 Files selected for processing (1)

• src/components/DialogManager/Dialog.module.scss

---

Walkthrough

The PR adjusts dialog sizing CSS rules in Dialog.module.scss. For full-height dialogs, the strategy switches from constraining dimensions with height/max-height and --dialog-usable-height to using min-height with --dialog-max-height. For full-width dialogs, the strategy similarly shifts from constraining with width/max-width and --dialog-usable-width to using min-width with --dialog-max-width. This represents a semantic change in how dialog sizing constraints are applied, moving from a fixed/maximum constraint model to a minimum-based model.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically references the main change: adjusting Dialog component's fullWidth behavior to override maxWidth via CSS selector changes in Dialog.module.scss.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ian/cc-61-dialog-fullwidth-overrides-maxwidth

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Stylelint (17.11.0)

src/components/DialogManager/Dialog.module.scss

ConfigurationError: Could not find "stylelint-config-clean-order". Do you need to install the package or use the "configBasedir" option?
at getModulePath (file:///usr/local/lib/node_modules/stylelint/lib/utils/getModulePath.mjs:29:9)
at loadExtendedConfig (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:285:21)
at extendConfig (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:252:25)
at async augmentConfigBasic (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:85:20)
at async augmentConfigFull (file:///usr/local/lib/node_modules/stylelint/lib/augmentConfig.mjs:138:24)
at async getConfigForFile (file:///usr/local/lib/node_modules/stylelint/lib/getConfigForFile.mjs:102:26)
at async resolveOptionValue (file:///usr/local/lib/node_modules/stylelint/lib/utils/resolveOptionValue.mjs:27:24)
at async standalone (file:///usr/local/lib/node_modules/stylelint/lib/standalone.mjs:127:22)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}