Fixed file visitor for extracting exception messages #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
reviewed
May 10, 2023
Member
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
Given the logic here is quite complicated, maybe we can have unit test coverage to fully understand what's going on?
src/lib/MVC/Symfony/Translation/ExceptionMessageTemplateFileVisitor.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
May 10, 2023
tests/lib/MVC/Symfony/Translation/ExceptionMessageTemplateFileVisitorTest.php
Show resolved
Hide resolved
alongosz
approved these changes
May 10, 2023
konradoboza
reviewed
May 10, 2023
src/lib/MVC/Symfony/Translation/ExceptionMessageTemplateFileVisitor.php
Outdated
Show resolved
Hide resolved
tests/lib/MVC/Symfony/Translation/ExceptionMessageTemplateFileVisitorTest.php
Outdated
Show resolved
Hide resolved
tests/lib/MVC/Symfony/Translation/fixtures/NoTranslationToExtract.php
Outdated
Show resolved
Hide resolved
tests/lib/MVC/Symfony/Translation/fixtures/NoTranslationToExtract.php
Outdated
Show resolved
Hide resolved
tests/lib/MVC/Symfony/Translation/fixtures/SetMessageTemplate.php
Outdated
Show resolved
Hide resolved
tests/lib/MVC/Symfony/Translation/fixtures/WrongTranslationId.php
Outdated
Show resolved
Hide resolved
mikadamczyk
force-pushed
the
fixed_translation_visitor
branch
from
b11853f to
d946511
Compare
konradoboza
approved these changes
May 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mikadamczyk
force-pushed
the
fixed_translation_visitor
branch
from
d946511 to
88d052f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5Because of this error wrong translation domain was created (messages) during the process of translation extraction in the
ibexa/seopackage. The correct domain should berepository_exceptions. The file in theseopackage could be found here https://github.com/ibexa/seo/blob/main/src/bundle/Resources/translations/repository_exceptions.en.xliff.Checklist:
$ composer fix-cs).@ibexa/engineering).