Fixed translation configuration #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mikadamczyk
force-pushed
the
fixed_translation_configuration
branch
from
f1efc5d to
ff08a72
Compare
alongosz
approved these changes
May 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
adamwojs
reviewed
May 20, 2023
| ], | ||
| 'output_dir' => __DIR__ . '/../Resources/translations/', | ||
| 'output_format' => 'xliff', | ||
| 'output_format' => 'xlf', |
Member
There was a problem hiding this comment.
Why we are changing output format to xlf ?
kisztof
suggested changes
May 23, 2023
| ], | ||
| 'output_dir' => __DIR__ . '/../Resources/translations/', | ||
| 'output_format' => 'xliff', | ||
| 'output_format' => 'xlf', |
Contributor
Author
|
@adamwojs , @kisztof This pull request tries to revert/cleanup changes introduced in #184. All existing translations before this pull request were in |
adamwojs
approved these changes
Aug 22, 2023
mikadamczyk
force-pushed
the
fixed_translation_configuration
branch
from
a46580c to
f19d065
Compare
mikadamczyk
force-pushed
the
fixed_translation_visitor
branch
from
d946511 to
88d052f
Compare
mikadamczyk
force-pushed
the
fixed_translation_configuration
branch
from
f19d065 to
9201602
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mikadamczyk
added a commit
that referenced
this pull request
Aug 24, 2023
* Fixed file visitor for extracting exception messages * Fixed translation configuration (#237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5Fixes a path from which translations will be extracted and an extension of generated files.
Checklist:
$ composer fix-cs).@ibexa/engineering).