IBX-5111: Introduced custom find and result extracting capabilities#239
Closed
konradoboza wants to merge 1 commit intomainfrom
Closed
IBX-5111: Introduced custom find and result extracting capabilities#239konradoboza wants to merge 1 commit intomainfrom
konradoboza wants to merge 1 commit intomainfrom
Conversation
55676c9 to
4c1efd7
Compare
d0299d8 to
e011a31
Compare
9373d3c to
17988ef
Compare
17988ef to
a5ab49f
Compare
a5ab49f to
fcb7c28
Compare
Steveb-p
reviewed
Jun 19, 2023
Comment on lines
+13
to
+15
| /** | ||
| * @param array{}|array{languages: array<string>, useAlwaysAvailable: bool} $languageFilter | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @param array{}|array{languages: array<string>, useAlwaysAvailable: bool} $languageFilter | |
| */ | |
| /** | |
| * @param array{languages?: array<string>, useAlwaysAvailable?: bool} $languageFilter | |
| */ |
|
SonarCloud Quality Gate failed.
|
Steveb-p
reviewed
Jun 19, 2023
|
|
||
| namespace Ibexa\Contracts\Core\Repository\Values\Search; | ||
|
|
||
| interface SearchContextInterface |
Contributor
There was a problem hiding this comment.
Note that Context implies that there might be parameters that are outside of our current expectations that are used by third party code. In my opinion it should be flexible enough that any underlying search engine could pick parameters that it is interested in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










v4.6Checklist:
$ composer fix-cs).@ibexa/php-dev).