IBX-9421: Fixed global @serializer service overwriting Ibexa serializer variant#468
Merged
IBX-9421: Fixed global @serializer service overwriting Ibexa serializer variant#468
@serializer service overwriting Ibexa serializer variant#468Conversation
emodric
changed the title
adamwojs
approved these changes
Jan 30, 2025
Steveb-p
approved these changes
Jan 30, 2025
Co-authored-by: Paweł Niedzielski <pawel.tadeusz.niedzielski@gmail.com>
|
konradoboza
approved these changes
Jan 30, 2025
tbialcz
approved these changes
Jan 31, 2025
alongosz
changed the title
@serializer service overwriting Ibexa serializer variant
alongosz
approved these changes
Jan 31, 2025
This was referenced Feb 5, 2025
micszo
approved these changes
Feb 5, 2025
Contributor
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
Reproduced and retested on frontend and in back-office.
Tested on Ibexa Commerce 4.6.17-dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The problem here stems from
Ibexa\Core\MVC\Symfony\Component\Serializer\CompoundMatcherNormalizerbeing erroneously tagged withserializer.normalizertag, which means that once the global@serializerservice is initialized (e.g. when used in a listener as outlined in the issue description), the Ibexa variant of the serializer which was injected intoCompoundMatcherNormalizerwill be overwritten by the global instance, causing the problem described in the issue.