IBX-11130: Fixed proxy initializer returning null
#693
+74
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibexa-workflow-automation-1
bot
requested review from
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
reviewed
Dec 23, 2025
konradoboza
approved these changes
Dec 23, 2025
barw4
approved these changes
Dec 29, 2025
tomaszszopinski
force-pushed
the
fix-11130
branch
from
972e4c1 to
ba28bb4
Compare
|
|
Commerce regression: ibexa/commerce#1667 🟢 |
tomaszszopinski
approved these changes
Jan 29, 2026
alongosz
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where Proxy initialization function was ignoring the fact that
ThumbnailStrategydid not return an object.Throughout our codebase we often rely on
$thumbnail === nullchecks done against proxy. If subsequently a method is called on a proxy with initializer that allows returningnull(which is usually the case with proxy) the error becomes very difficult to debug.For QA:
Might be difficult to find cases in local product catalog where this occurs. This was reproduced in Quable Connector where thumbnail might not be present.
So, it might not be easily reproducible (and I don't have steps other than manual "breaking" of code). Sanities should be enough?
Documentation: