Skip to content

IBX-11259: Fixed download file by id by additionally handling queries version and language#718

Merged
barw4 merged 1 commit into4.6from
ibx-11259-download-file-lang-version
Mar 6, 2026
Merged

IBX-11259: Fixed download file by id by additionally handling queries version and language#718
barw4 merged 1 commit into4.6from
ibx-11259-download-file-lang-version

Conversation

@barw4
Copy link
Copy Markdown
Contributor

@barw4 barw4 commented Feb 26, 2026

🎫 Issue IBX-11259

Description:

For QA:

Documentation:

@barw4 barw4 self-assigned this Feb 26, 2026
@barw4 barw4 added Bug Something isn't working Ready for review labels Feb 26, 2026
@barw4 barw4 changed the title IBX-11259: Fixed download file by id to handle version and language IBX-11259: Fixed download file by id by additionally handling queries version and language Feb 26, 2026
@barw4 barw4 requested a review from a team February 26, 2026 08:40
Copy link
Copy Markdown
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth it tho, but I would rather have version and language as additional parameters to those two - methodsdownloadBinaryFileAction/downloadBinaryFileByIdAction

@barw4
Copy link
Copy Markdown
Contributor Author

barw4 commented Feb 26, 2026

Probably not worth it tho, but I would rather have version and language as additional parameters to those two - methodsdownloadBinaryFileAction/downloadBinaryFileByIdAction

I thought about it but that would require larger refactoring including admin-ui

@KamilSznajdrowicz KamilSznajdrowicz force-pushed the ibx-11259-download-file-lang-version branch from c5310a0 to 29a31fc Compare March 5, 2026 08:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

Copy link
Copy Markdown

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tested on 4.6.x-dev, patch applied and successfully tested on v4.6.18

@barw4 barw4 merged commit beece8c into 4.6 Mar 6, 2026
21 checks passed
@barw4 barw4 deleted the ibx-11259-download-file-lang-version branch March 6, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working QA approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants