IBX-11766: Replaced phpunit assertions with webmozart equivalents#753
Merged
konradoboza merged 4 commits intoMay 22, 2026
Merged
Conversation
bnowak
force-pushed
the
IBX-11766-replace-phpunit-assertions-with-webmozart-library
branch
from
a3a6701 to
52a38fa
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bnowak
force-pushed
the
IBX-11766-replace-phpunit-assertions-with-webmozart-library
branch
from
52a38fa to
d7b89a6
Compare
ViniTou
reviewed
May 21, 2026
| $expectedSiteaccessName, | ||
| $siteaccessList = $this->getConfigResolver()->getParameter('siteaccess.default_siteaccess') | ||
| Assertion::eq( | ||
| $siteaccessList = $this->getConfigResolver()->getParameter('siteaccess.default_siteaccess'), |
Contributor
There was a problem hiding this comment.
comment from sonarcloud seems valid and can be applied here.
Remove this unused "$siteaccessList" local variable.
…text\ConsoleContext::thereIsADefaultSiteaccess
|
konradoboza
approved these changes
May 21, 2026
ViniTou
approved these changes
May 21, 2026
konradoboza
deleted the
IBX-11766-replace-phpunit-assertions-with-webmozart-library
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/behat#184
Description:
Installed
webmozart/assertlibrary as require-dev dependency. It's still a bit "hidden" dependency (because behat package use assertions from /src directory), but at least it's defined in this specific library. Previously, phpunit was installed by indirect dependency fromibexa/behatpackage.Replaced phpunit assertions with these from webmozart library.
For QA:
Documentation: