Skip to content

Conversation

@reithor
Copy link
Contributor

@reithor reithor commented May 3, 2022

Fix version specific notes for releases <=v2.1.1 and <=v2.4.1

@reithor reithor requested review from DominikaK and adriendupuis May 3, 2022 13:08
When updating a release **earlier than v2.5.0**, some version-specific changes are required.

### A. v2.2
### A. Update from <=v2.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer

Suggested change
### A. Update from <=v2.1.1
### A. Update from earlier than v2.2

If not, maybe the use of instead of <=

Suggested change
### A. Update from <=v2.1.1
### A. Update from v2.1.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I am definitely fine with "from earlier than v2.2" (or v2.2.0)

## 3. Version Specific changes

First, perform version-specific steps depending on which version you are updating from.
When updating a release **earlier than v2.5.0**, some version-specific changes are required.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reithor, in general, can you explain the reason for this change? We use the same structure for all update pages (see https://doc.ibexa.co/en/master/updating/from_3.3/update_from_3.3/#v332 for example), so changing it here would require reformulating the headings everywhere in the update section for consistency.
If I understand correctly and the issue is: "we are updating to v2.2, not from v2.2", I'd prefer rephrasing this introductory sentence:

Suggested change
When updating a release **earlier than v2.5.0**, some version-specific changes are required.
First, perform version-specific steps depending on which version you are updating to.

Copy link
Contributor Author

@reithor reithor May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikaK : changing the structure is not neccessary - I just thought it woul be clearer.
The whole point of the PR is that :
"A. v2.2" --> should be "A. Update from earlier than v2.2"
"B. v2.5" --> should be "B. Update from earlier than v2.5"

@reithor
Copy link
Contributor Author

reithor commented May 5, 2022

replaced by #1609

@reithor reithor closed this May 5, 2022
@MagdalenaZuba MagdalenaZuba deleted the fix_update_to_2.5 branch April 19, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants