- 
                Notifications
    
You must be signed in to change notification settings  - Fork 81
 
Fix version specific notes #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| When updating a release **earlier than v2.5.0**, some version-specific changes are required. | ||
| 
               | 
          ||
| ### A. v2.2 | ||
| ### A. Update from <=v2.1.1 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer
| ### A. Update from <=v2.1.1 | |
| ### A. Update from earlier than v2.2 | 
If not, maybe the use of  ≤ instead of <=
| ### A. Update from <=v2.1.1 | |
| ### A. Update from ≤v2.1.1 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I used "<=" because I have seen it here https://doc.ibexa.co/en/2.5/updating/from_1.x_2.x/update_app_to_2.5/#c-prepare-for-pulling-changes
 - "earlier than" is less specific than "<=v2.1.1"
 
but I am definitely fine with "from earlier than v2.2" (or v2.2.0)
| ## 3. Version Specific changes | ||
| 
               | 
          ||
| First, perform version-specific steps depending on which version you are updating from. | ||
| When updating a release **earlier than v2.5.0**, some version-specific changes are required. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reithor, in general, can you explain the reason for this change? We use the same structure for all update pages (see https://doc.ibexa.co/en/master/updating/from_3.3/update_from_3.3/#v332 for example), so changing it here would require reformulating the headings everywhere in the update section for consistency.
If I understand correctly and the issue is: "we are updating to v2.2, not from v2.2", I'd prefer rephrasing this introductory sentence:
| When updating a release **earlier than v2.5.0**, some version-specific changes are required. | |
| First, perform version-specific steps depending on which version you are updating to. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikaK : changing the structure is not neccessary - I just thought it woul be clearer.
The whole point of the PR is that :
"A. v2.2" --> should be "A. Update from earlier than v2.2"
"B. v2.5" --> should be "B. Update from earlier than v2.5"
| 
           replaced by #1609  | 
    
Fix version specific notes for releases <=v2.1.1 and <=v2.4.1