Fix "Create Form Builder Form attribute" #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

adriendupuis merged 11 commits into master from fix-create-form-attr

Jun 20, 2024

Contributor

adriendupuis commented Jun 13, 2024 •

edited

Loading

Question	Answer
JIRA Ticket
Versions	master, 4.6, 4.5
Edition	Experience, Commerce

Use dedicated assets/js/ folder instead of generic public/js/ folder
Fix configuration key from ibexa_form_builder_fields to ibexa_form_builder.fields
Fix attribute name missing space
Frame illustration
Add more illustrations of the resulting attribute

Comparison:

Checklist

Text renders correctly
Text has been checked with vale
Description metadata is up to date
Redirects cover removed/moved pages
Code samples are working
PHP code samples have been fixed with PHP CS fixer
Added link to this PR in relevant JIRA ticket or code PR


          create_form_attribute: Fix config key

471d54a

adriendupuis added the Work in progress label

adriendupuis added 5 commits

June 17, 2024 18:49


          create form attribute: move JS from public/ to assets/

7ddb87c


          form_attribute_config.yaml: Add missing space

376be93


          Move create_form_attribute.md illustration

d403ab9


          Update create_form_attribute.md illustration

808d506


          create_form_attribute.md: Add more illustrations

034eebf

adriendupuis marked this pull request as ready for review

June 19, 2024 09:43

adriendupuis added Needs DOC review and removed Work in progress labels

adriendupuis commented

View reviewed changes

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

adriendupuis commented

View reviewed changes

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

adriendupuis commented

View reviewed changes

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

adriendupuis commented

View reviewed changes

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

adriendupuis commented

View reviewed changes

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

julitafalcondusza requested changes

View reviewed changes

Contributor

julitafalcondusza left a comment

Please see my comments.

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

docs/content_management/forms/img/checkbox_with_richtext_description-preview.png Show resolved Hide resolved

docs/content_management/forms/create_form_attribute.md Outdated Show resolved Hide resolved

adriendupuis and others added 3 commits

June 19, 2024 12:58


          Apply suggestions from code review

f8fea01


          Enlarge checkbox_with_richtext_description-preview.png

840628f


          Apply suggestions from code review

af343cc

Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>

adriendupuis commented

View reviewed changes

code_samples/forms/custom_form_attribute/config/packages/form_attribute_config.yaml Outdated Show resolved Hide resolved

adriendupuis added 2 commits

June 19, 2024 15:28


          Update code_samples/forms/custom_form_attribute/config/packages/form_…

9e4f084

…attribute_config.yaml


          configure_elastic_search.md: "Rich Text"

e917bba

adriendupuis requested a review from julitafalcondusza

June 19, 2024 13:44

julitafalcondusza approved these changes

View reviewed changes

dabrt approved these changes

View reviewed changes

adriendupuis added Ready for MERGE and removed Needs DOC review labels

adriendupuis merged commit 7b98a91 into master

adriendupuis deleted the fix-create-form-attr branch

June 20, 2024 15:43

adriendupuis added a commit that referenced this pull request


          Fix "Create Form Builder Form attribute" (#2402)

7e326e1

(cherry picked from commit 7b98a91)

adriendupuis added a commit that referenced this pull request


          Fix "Create Form Builder Form attribute" (#2402)

49bef86

(cherry picked from commit 7b98a91)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for MERGE