[CDP] Corrected configuration #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Aug 12, 2024
mnocon
requested review from
adriendupuis,
dabrt,
julitafalcondusza and
juskora
julitafalcondusza
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: master, 4.6
Preview: https://ez-systems-developer-documentation--2465.com.readthedocs.build/en/2465/cdp/cdp_activation/cdp_configuration/
The current config will result in
Invalid type for path "ibexa.system.default.cdp.activations.segment_group_identifier". Expected "array", but got "string"error, as reported by @konradoboza .Fixed this by adding the missing array - an example of a valid configuration is in the recipes:
https://github.com/ibexa/recipes-dev/blob/master/ibexa/cdp/4.6/config/packages/ibexa_cdp.yaml#L25-L31
I've also updated the example config identifier (so that it's consistent with the recipe) - but I'm not adamant on this change.
Checklist