[Custom Attribute type] Corrected StorageSchema import #2474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: master, 4.6
The Custom Attribute type example is using the
Ibexa\ProductCatalog\Local\Persistence\Legacy\Attribute\Boolean\StorageSchemaclass, but it's confusing - it should be using theIbexa\ProductCatalog\Local\Persistence\Legacy\Attribute\Float\StorageSchemaclass.Reasoning:
It works by accident (because
Ibexa\ProductCatalog\Local\Persistence\Legacy\Attribute\Boolean\StorageSchema::COLUMN_VALUEandIbexa\ProductCatalog\Local\Persistence\Legacy\Attribute\Float\StorageSchema::COLUMN_VALUEhave the same value -value), but it's better to make it consistent.See:
Preview:
https://ez-systems-developer-documentation--2474.com.readthedocs.build/en/2474/pim/create_custom_attribute_type/#storage-converter