Skip to content

Enhance create page blocks doc #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2024
Merged

Enhance create page blocks doc #2514

merged 4 commits into from
Oct 14, 2024

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Oct 8, 2024 •
edited
Loading

Question Answer
JIRA Ticket N/A
Versions master, 4.6
Edition ??

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis marked this pull request as ready for review October 8, 2024 22:30
@adriendupuis adriendupuis requested a review from reithor October 8, 2024 22:30
reithor
reithor reviewed Oct 9, 2024
View reviewed changes
@adriendupuis @reithor
Update docs/content_management/pages/create_custom_page_block.md
b37887f 
Co-authored-by: Thorsten Reiter <34274688+reithor@users.noreply.github.com>
@reithor reithor self-requested a review October 9, 2024 10:09
reithor
reithor approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@reithor reithor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mnocon
mnocon reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this, it was indeed easy to miss this remark.

I have two small suggestions - but feel free to modify them as you see fit

@adriendupuis @mnocon
Apply suggestions from code review
59ddbee 
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
@adriendupuis adriendupuis requested a review from mnocon October 14, 2024 11:52
mnocon
mnocon approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adriendupuis adriendupuis merged commit 2a6e0f0 into master Oct 14, 2024
6 checks passed
@adriendupuis adriendupuis deleted the create-page-blocks branch October 14, 2024 12:40
adriendupuis added a commit that referenced this pull request Oct 14, 2024
@adriendupuis @reithor @mnocon
Enhance create page blocks doc (#2514)
9dcbc85 
* create_custom_page_block.md: Highlight that new block must be enabled in BO
* data_migration_actions.md: Add `add_block_to_available_blocks` example

---------

Co-authored-by: Thorsten Reiter <34274688+reithor@users.noreply.github.com>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
(cherry picked from commit 2a6e0f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnocon mnocon mnocon approved these changes

@reithor reithor reithor approved these changes

Assignees

No one assigned

Labels

Needs DEV review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adriendupuis @mnocon @reithor