Skip to content

IBX-9124: Dynamic attribute submodels described in Developer Documentation #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2024
Merged

IBX-9124: Dynamic attribute submodels described in Developer Documentation #2523

merged 4 commits into from
Oct 29, 2024

Conversation

@julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Oct 23, 2024 •
edited
Loading

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-9124)
Versions 3.3+

Dynamic attribute submodels described in Developer Documentation.

Preview: https://ez-systems-developer-documentation--2523.com.readthedocs.build/en/2523/personalization/api_reference/recommendation_api/#submodel-parameters

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Added link to this PR in relevant JIRA ticket or code PR

@julitafalcondusza julitafalcondusza marked this pull request as ready for review October 29, 2024 10:42
mnocon
mnocon reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One small suggestion for the wording - and other one when it comes to the consistency of the endpoint in the examples

mnocon
mnocon approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julitafalcondusza julitafalcondusza merged commit 7ab238a into master Oct 29, 2024
6 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-9124 branch October 29, 2024 13:56
julitafalcondusza added a commit that referenced this pull request Oct 29, 2024
@julitafalcondusza
IBX-9124: Dynamic attribute submodels described in Developer Document…
620d661 
…ation (#2523)

* Dynamic attribute submodels

* Update

* fix

* fix after doc review
julitafalcondusza added a commit that referenced this pull request Oct 29, 2024
@julitafalcondusza
IBX-9124: Dynamic attribute submodels described in Developer Document…
40851eb 
…ation (#2523)

* Dynamic attribute submodels

* Update

* fix

* fix after doc review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnocon mnocon mnocon approved these changes

+2 more reviewers

@dkorostynski dkorostynski dkorostynski approved these changes

@kaborkowski kaborkowski kaborkowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@julitafalcondusza @mnocon @dkorostynski @kaborkowski