Skip to content

IBX-11083: Extending collaboration described in Developer Documentation (4.6)#3094

Merged
adriendupuis merged 21 commits into4.6from
IBX-11083-4.6
Mar 24, 2026
Merged

IBX-11083: Extending collaboration described in Developer Documentation (4.6)#3094
adriendupuis merged 21 commits into4.6from
IBX-11083-4.6

Conversation

@adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 18, 2026

Question Answer
JIRA Ticket IBX-11083
Versions 4.6
Edition All

Port #3055 back to Ibexa DXP v4.6 on PHP 7.4

  • Remove argument promoted to properties
  • Remove constant typing
  • Caught exception must be stored into a variable
  • Move from #[Route( attribute to /** @Route( annotation
  • Remove other PHP attributes
  • Remove trailing coma from function argument list
  • Use services.yaml from 4.6 clean install

Side note: I needed 715df2c to install locally as utf8 was mapped to utf8mb3 which brings constraint failures. (Sorry for committing directly to 4.6 without PR.)

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

julitafalcondusza and others added 2 commits March 18, 2026 11:55
…on (#3055)

* extending collaboration described in dev-doc

* PHP & JS CS Fixes

* Trigger CI

* fixes

* PHP & JS CS Fixes

* card added

* fixes after dev-rev

* [PHPStan] Fixed reported errors

* IBX-11083: Add missing code, fix code (#3078)

* Add services.yaml and Mapper.php

* Move SQL to files

* Remove copyright for sharability

* Rector

* collaboration_search_reference: Fix highlights

* collaboration/config/services.yaml: Fixes

* collaboration/config/services.yaml: Format

* Move template to storefront theme

standard/cart/view.html.twig is always overridden by storefront/cart/view.html.twig from the bundle

As the template depends on and extends the storefront theme, they're part of it.

* Redesign share.html.twig for storefront

* Simplify cart/view.html.twig

* Redesign share_result.html.twig for storefront

* screenshots added

* screenshots added

* fixes

* small fixes

---------

Co-authored-by: julitafalcondusza <julitafalcondusza@users.noreply.github.com>
Co-authored-by: Tomasz Kryszan <tomasz.kryszan@ibexa.co>
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
* CartResolverDecorator: Use generic UnauthorizedException
* ~~deptrac.baseline.yaml: Ignore non-Contracts collab classes~~
@adriendupuis adriendupuis changed the base branch from 5.0 to 4.6 March 18, 2026 11:01
@adriendupuis adriendupuis marked this pull request as ready for review March 19, 2026 15:44
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, looks good otherwise (checked include_file and hl_lines usage for broken code samples, did not find anything)

Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

code_samples/ change report

Report's diff is too long to be displayed in a comment.

Download colorized diff

@adriendupuis adriendupuis merged commit b6002ac into 4.6 Mar 24, 2026
9 checks passed
@adriendupuis adriendupuis deleted the IBX-11083-4.6 branch March 24, 2026 15:21
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants