Skip to content

IBX-9681: Discounts described in user doc #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 30, 2025
Merged

IBX-9681: Discounts described in user doc #359

merged 10 commits into from
Jun 30, 2025

Conversation

@dabrt
Copy link
Contributor

@dabrt dabrt commented Jun 20, 2025

Question Answer
JIRA Ticket IBX-9681
Versions 4.6 and up (LTS Update)
Edition Commerce

Described Discounts in user doc

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Added link to this PR in relevant JIRA ticket or code PR

konradoboza
konradoboza approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. What is maybe worth mentioning somewhere, is that system selects only one discount for the product that fits the most in the current context.

katarzynazawada
katarzynazawada reviewed Jun 24, 2025
View reviewed changes
@dabrt dabrt requested a review from katarzynazawada June 24, 2025 13:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mnocon
mnocon approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dabrt dabrt merged commit e0315ee into 5.0 Jun 30, 2025
8 checks passed
@dabrt dabrt deleted the IBX-9681 branch June 30, 2025 05:59
dabrt added a commit that referenced this pull request Jun 30, 2025
@dabrt
IBX-9681: Discounts described in user doc (#359)
bd7c7bf 
* IBX-9681: Discounts described in user doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@julitafalcondusza julitafalcondusza Awaiting requested review from julitafalcondusza

Assignees

No one assigned

Labels

Needs DOC review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dabrt @mnocon @konradoboza @katarzynazawada