-
Notifications
You must be signed in to change notification settings - Fork 8
Added mention about cross-site linking #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview of modified filesPreview of modified Markdown: |
2671cbf to
eff0e0d
Compare
| When you select a section of text, you get access to text formatting options such as bold or underline. | ||
| Here you can also add a link to the text. You can link to an external website, or to another content item. | ||
|
|
||
| When linking to content, you can select a SiteAccess from the drop-down to enable cross-website linking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term SiteAccess can be hard to grasp for end-users. You could repeat the link used above to a definition of SA:
translate_content.md#siteaccess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could a screen shot of the link "editor" with the site select unfold worth it?
reithor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with :
@dabrt that link to SiteAccess explanation could be added.
@adriendupuis that a screenshot would be very beneficial
|
|
Thank you! New link and screenshot added in 87dea6d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ibexa/fieldtype-richtext/blob/main/src/lib/RichText/Validator/InternalLinkValidator.php#L70
One more not-yet-rebranded feature 😅
* Added mention about cross-site linking * Review feedback



Jira: https://ibexa.atlassian.net/browse/IBX-9266
Target: 4.6, 5.0