Skip to content

Conversation

@landonreed
Copy link
Contributor

@landonreed landonreed commented Jul 31, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Fix #333 by storing GTFS files with the correct file name.

@landonreed landonreed requested a review from evansiroky July 31, 2020 15:34
@landonreed landonreed changed the base branch from dev to improve-monitorable-server-job-exception-handling July 31, 2020 15:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #334 into improve-monitorable-server-job-exception-handling will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                                   Coverage Diff                                   @@
##             improve-monitorable-server-job-exception-handling     #334      +/-   ##
=======================================================================================
+ Coverage                                                23.91%   23.96%   +0.05%     
- Complexity                                                 538      539       +1     
=======================================================================================
  Files                                                      168      168              
  Lines                                                     8841     8841              
  Branches                                                  1223     1223              
=======================================================================================
+ Hits                                                      2114     2119       +5     
+ Misses                                                    6519     6514       -5     
  Partials                                                   208      208              
Flag Coverage Δ Complexity Δ
#unit_tests 23.96% <100.00%> (+0.05%) 539.00 <1.00> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...veyal/datatools/manager/persistence/FeedStore.java 35.23% <100.00%> (+4.76%) 15.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579719c...f6f020a. Read the comment docs.

@binh-dam-ibigroup
Copy link
Contributor

Should this be merged to the dev branch?

}

@Test
public void canCreateTempGtfsFile() throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment for this test case?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Herzlichen Dank für die Unterstützung,

klappt leider nicht.
Sorry mein Englisch ist schlecht.
LG

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test case could use some comments, but other than that, it's good.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jul 31, 2020
@landonreed landonreed merged commit bdc3e6b into improve-monitorable-server-job-exception-handling Aug 3, 2020
@landonreed landonreed deleted the fix-tmp-gtfs-creation branch August 3, 2020 14:34
@evansiroky evansiroky mentioned this pull request Aug 19, 2020
8 tasks
@landonreed landonreed mentioned this pull request Oct 30, 2020
8 tasks
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeedStore storing tmp GTFS with .tmp suffix

6 participants