-
Notifications
You must be signed in to change notification settings - Fork 52
Fix tmp gtfs creation #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tmp gtfs creation #334
Conversation
Codecov Report
@@ Coverage Diff @@
## improve-monitorable-server-job-exception-handling #334 +/- ##
=======================================================================================
+ Coverage 23.91% 23.96% +0.05%
- Complexity 538 539 +1
=======================================================================================
Files 168 168
Lines 8841 8841
Branches 1223 1223
=======================================================================================
+ Hits 2114 2119 +5
+ Misses 6519 6514 -5
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Should this be merged to the dev branch? |
| } | ||
|
|
||
| @Test | ||
| public void canCreateTempGtfsFile() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment for this test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Herzlichen Dank für die Unterstützung,
klappt leider nicht.
Sorry mein Englisch ist schlecht.
LG
evansiroky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test case could use some comments, but other than that, it's good.
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Checklist
devbefore they can be merged tomaster)Description
Fix #333 by storing GTFS files with the correct file name.