Skip to content

Conversation

@landonreed
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

New version release with the following PRs: #553, #588, #579, #591, #545, #594, #597, #595, #601, #596, #600, #551, #602, #603

landonreed and others added 30 commits March 16, 2020 10:56
Add GTFS+ validation issue details
…idth to 120

Changed trip_short_name width to 120 from 200 of previous commit

Close #569
dependabot bot and others added 7 commits July 30, 2020 17:03
…s/auth0-2.27.1

build(deps-dev): bump auth0 from 2.18.0 to 2.27.1 in /scripts
fix(gtfs.yml): add more currency types for fares
…s/extend-3.0.2

build(deps): bump extend from 3.0.1 to 3.0.2 in /scripts
@landonreed
Copy link
Contributor Author

@evansiroky, it looks like the e2e tests are broken again. Any insights? Looks like the OTP router is registered, but the trip could not be planned: https://travis-ci.org/github/ibi-group/datatools-ui/builds/716913172#L1981

@evansiroky
Copy link
Contributor

This appears to be happening because of the problem that was fixed in ibi-group/datatools-server#334. That PR was merged into the branch that ibi-group/datatools-server#331 is using, so once that gets merged into dev, these e2e tests should start passing again.

@evansiroky evansiroky added BLOCKED Blocked (waiting on another PR to be merged) and removed BLOCKED Blocked (waiting on another PR to be merged) labels Aug 19, 2020
@evansiroky
Copy link
Contributor

Blocked until ibi-group/datatools-server#336 is merged and a new jar is uploaded.

@evansiroky evansiroky added the BLOCKED Blocked (waiting on another PR to be merged) label Aug 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #604 into master will decrease coverage by 0.43%.
The diff coverage is 26.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   43.89%   43.45%   -0.44%     
==========================================
  Files         315      323       +8     
  Lines       17270    17589     +319     
  Branches     5269     5363      +94     
==========================================
+ Hits         7581     7644      +63     
- Misses       8443     8670     +227     
- Partials     1246     1275      +29     
Flag Coverage Δ
#end_to_end_tests 44.16% <26.68%> (-0.50%) ⬇️
#unit_tests 15.67% <6.88%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/common/util/config.js 80.00% <0.00%> (ø)
lib/editor/selectors/timetable.js 62.35% <ø> (ø)
lib/gtfsplus/components/GtfsPlusVersionSummary.js 0.00% <0.00%> (ø)
...manager/components/transform/FeedTransformation.js 0.00% <0.00%> (ø)
...components/transform/FeedTransformationSettings.js 0.00% <0.00%> (ø)
...ib/manager/components/version/FeedVersionReport.js 47.91% <0.00%> (-4.26%) ⬇️
lib/types/index.js 0.00% <0.00%> (ø)
...manager/components/transform/FeedTransformRules.js 1.51% <1.51%> (ø)
lib/manager/actions/status.js 61.11% <5.88%> (+0.61%) ⬆️
lib/manager/components/FeedSourceSettings.js 41.37% <18.18%> (-12.25%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c5627...71eb526. Read the comment docs.

@evansiroky
Copy link
Contributor

Test are passing again. Unblocking.

@evansiroky evansiroky removed the BLOCKED Blocked (waiting on another PR to be merged) label Sep 29, 2020
@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Sep 30, 2020
@landonreed landonreed merged commit b2db337 into master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants