Upload branch jar again

[evansiroky]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

This PR brings back the uploading of a jar with the name of the latest branch. The e2e tests in datatools-ui depend on downloading the latest jar from a particular branch name.

[codecov-commenter]

Codecov Report

Merging #336 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #336   +/-   ##
=========================================
  Coverage     24.04%   24.04%           
  Complexity      542      542           
=========================================
  Files           169      169           
  Lines          8895     8895           
  Branches       1230     1230           
=========================================
  Hits           2139     2139           
  Misses         6543     6543           
  Partials        213      213           

Flag	Coverage Δ	Complexity Δ
#unit_tests	24.04% <ø> (ø)	542.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d068810...46f3919. Read the comment docs.

[landonreed]

Is #321 still a problem? I expect that it probably is.

[evansiroky]

It seems to have worked this time: https://travis-ci.org/github/ibi-group/datatools-server/builds/720900545#L11247. Maybe merge this and if the problem happens again, I'll investigate further?

[binh-dam-ibigroup]

I am neutral regarding this and the last CI build went well, so I'm going ahead and pre-approve.

[landonreed]

I don't think #321 is fixed. It only will fail on merges to master, but here's the travis snippet that causes the issue:

$ ls target/*.jar
target/datatools-server-3.6.1-SNAPSHOT.jar
target/datatools-server-3.7.0.jar
target/dt-v3.2.0-760-g2f3ec00.jar
target/dt-v3.2.0-804-g3a93b0a.jar
$ cp target/dt-*.jar deploy/
$ cp target/dt-*.jar "deploy/dt-latest-$BRANCH_CLEAN.jar"
cp: target ‘deploy/dt-latest-master.jar’ is not a directory
The command "cp target/dt-*.jar "deploy/dt-latest-$BRANCH_CLEAN.jar"" failed and exited with 1 during .

The issue is that there are multiple jars that it creates during CI and that it tries to copy all of them to a single filename.

[evansiroky]

See proposed code that fixes #321.

[landonreed]

Looks good, but I think this comment could be expanded a bit:

Get the first jar file and copy it into a new file that adds the current branch name. During a merge to master, there are multiple jar files produced, but they each effectively the same code (there may be slight differences in the version shown in the `pom.xml`, but that's not important for the purposes of creating this "latest branch" jar).

[landonreed]

Looks good, but I think the comment needs to say a bit more (see comment).

[landonreed]

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀