Skip to content

Conversation

@landonreed
Copy link
Contributor

@landonreed landonreed commented May 26, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

#577 introduced an issue in a refactor of the updateUserData action (a field name in the JSON payload was accidentally changed). This PR fixes that issue.

@landonreed
Copy link
Contributor Author

@binh-dam-ibigroup and @evansiroky, this is a very minor fix to #577 and I'm attempting to get the e2e stuff working again, so I'm just going to go ahead and merge. Feel free to provide any comments though and we can address later.

@codecov-commenter
Copy link

Codecov Report

Merging #578 into dev will decrease coverage by 22.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #578       +/-   ##
===========================================
- Coverage   38.42%   15.82%   -22.61%     
===========================================
  Files         315      315               
  Lines       17255    16085     -1170     
  Branches     5268     4895      -373     
===========================================
- Hits         6630     2545     -4085     
- Misses       9246    11557     +2311     
- Partials     1379     1983      +604     
Flag Coverage Δ
#end_to_end_tests ?
#unit_tests 15.82% <ø> (ø)
Impacted Files Coverage Δ
lib/manager/actions/user.js 16.10% <ø> (-29.74%) ⬇️
lib/manager/components/validation/TripsChart.js 0.00% <0.00%> (-80.40%) ⬇️
...nager/components/validation/ServicePerModeChart.js 0.00% <0.00%> (-78.27%) ⬇️
lib/common/util/map-keys.js 25.00% <0.00%> (-75.00%) ⬇️
lib/editor/components/EditorInput.js 0.00% <0.00%> (-72.79%) ⬇️
lib/manager/components/HomeProjectDropdown.js 0.00% <0.00%> (-72.73%) ⬇️
...b/manager/containers/ActiveFeedVersionNavigator.js 0.00% <0.00%> (-70.00%) ⬇️
lib/editor/components/EditorSidebar.js 0.00% <0.00%> (-66.67%) ⬇️
lib/editor/containers/ActiveGtfsEditor.js 0.00% <0.00%> (-66.67%) ⬇️
lib/manager/components/version/VersionDateLabel.js 0.00% <0.00%> (-66.67%) ⬇️
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed815f...c984474. Read the comment docs.

@landonreed landonreed merged commit 2b640af into dev May 26, 2020
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants