Skip to content

fix(user-update): fix user update error introduced in #577 #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
landonreed merged 1 commit into from
May 26, 2020
Merged

fix(user-update): fix user update error introduced in #577 #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion __tests__/end-to-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,8 @@ describe('end-to-end', () => {
await waitForAndClick(`[data-test-id="edit-user-${testUserSlug}"]`)
// $FlowFixMe cryptic error that is hard to resolve :(
const adminCheckbox = await page.$(`[data-test-id="app-admin-checkbox-${testUserSlug}"]`)
expect(await (await adminCheckbox.getProperty('checked')).jsonValue()).toBe(true)
const isAdmin = await (await adminCheckbox.getProperty('checked')).jsonValue()
expect(isAdmin).toBe(true)
}, defaultTestTimeout, 'should allow admin user to create another user')

makeTestPostLogin('should delete a user', async () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/actions/user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export function updateUserData (user: any, userData: any) {
const url = `/api/manager/secure/user/${user.user_id}`
const payload = {
user_id: profile.user_id,
app_metadata: metadata.datatools
data: metadata.datatools
}
let status
// Make request to server
Expand Down