This repository was archived by the owner on Mar 29, 2023. It is now read-only.
BUG: Fix import for new versions of ibis#59
Merged
tswast merged 1 commit intoibis-project:mainfrom May 20, 2021
Merged
Conversation
|
@tswast any issues here? |
Collaborator
|
I'd also like to make sure we maintain compatibility with ibis 1.4.0. At least until there are a few 2.x releases. I see there are some failing test in that build. https://github.com/ibis-project/ibis-bigquery/pull/59/checks?check_run_id=2630857546 e.g. |
tswast
reviewed
May 20, 2021
Contributor
Author
|
Sorry about that - I added another try/except so that the CI now passes: gerrymanoim#1. If I understand the github actions file, |
|
cc @tswast |
Contributor
Author
|
Sorry there are a few more places that need to be updated - will follow up in a bit. |
688940d to
f2b6cef
Compare
|
agree this is not pretty. @gerrymanoim can you create an issue to remove this code once |
tswast
approved these changes
May 20, 2021
Contributor
Author
renato2099
pushed a commit
to renato2099/ibis-bigquery
that referenced
this pull request
Jul 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler is now at https://github.com/ibis-project/ibis/blob/master/ibis/backends/base_sql/compiler.py