Merged
Conversation
remove double quotes
This reverts commit b339dfe.
whitfiea
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://jsw.ibm.com/browse/MASCORE-10280
Description
Why:
The addons app evaluates these flags as booleans. Previously, passing string values like "false" caused conditions to incorrectly evaluate as true, resulting in unwanted addon installation.
Passing values as booleans ensures that false is correctly interpreted and prevents misconfiguration.
Impact:
Addons will now be correctly supplied the values when set to false or true in the environment configuration.
Existing functionality for enabled addons remains unaffected.
Test Results
(https://openshift-gitops-server-openshift-gitops.apps.noble4.cp.fyre.ibm.com/applications/openshift-gitops/addons.noble4.sls01?resource=&operation=false&node=argoproj.io%2FApplication%2Fopenshift-gitops%2Faddons.noble4.sls01%2F0&tab=manifest)