Reduced API calls on System Parameters page #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedangimittal
commented
Jun 20, 2024
vedangimittal
commented
- Reduced API calls on System Parameters page for performance improvement
- Jira Story- https://jsw.ibm.com/browse/PFEBMC-2945
vedangimittal
force-pushed
the
system-parameters
branch
2 times, most recently
from
4f67d38 to
ce42837
Compare
vedangimittal
requested review from
Nikhil-Ashoka,
Renuka9527,
SteffiAntony and
nabilpandiyalayil
Author
|
Will remove the comments before getting it merged. |
| }, | ||
| actions: { | ||
| async getAggressivePrefetch({ commit }) { | ||
| async getApi({ commit }) { |
Collaborator
There was a problem hiding this comment.
Rename: "getApi" to "getBiosAttributesRegistry"
| }, | ||
| created() { | ||
| this.startLoader(); | ||
| Promise.all([ |
Collaborator
There was a problem hiding this comment.
No need of Promise.all as we are making only one API call
| }) | ||
| .catch((error) => console.log(error)); | ||
| }, | ||
| // async getAggressivePrefetch({ commit }) { |
| this.$store.dispatch('systemParameters/getRpdScheduledRun'), | ||
| this.$store.dispatch('systemParameters/getRpdScheduledRunDuration'), | ||
| this.$store.dispatch('systemParameters/getApi'), | ||
| // this.$store.dispatch('systemParameters/getLateralCastOutMode'), |
Nikhil-Ashoka
requested changes
Jul 11, 2024
Collaborator
Nikhil-Ashoka
left a comment
Nikhil-Ashoka
left a comment
There was a problem hiding this comment.
Please address the comments
vedangimittal
force-pushed
the
system-parameters
branch
2 times, most recently
from
bfee9e3 to
32c39b5
Compare
Comment on lines
322
to
329
| // async getLateralCastOutMode({ commit }) { | ||
| // const lateralCastOutMode = this.registryEntries.Attributes.filter( | ||
| // (Attribute) => Attribute.AttributeName == 'hb_lateral_cast_out_mode' | ||
| // ); | ||
| // let lateralCastOutModeValue = lateralCastOutMode[0].CurrentValue; | ||
| // let modeValue = lateralCastOutModeValue == 'Enabled' ? true : false; | ||
| // commit('setLateralCastOutMode', modeValue); | ||
| // }, |
vedangimittal
force-pushed
the
system-parameters
branch
from
32c39b5 to
badc84d
Compare
- Reduced API calls on System Parameters page for performance improvement - Jira Story- https://jsw.ibm.com/browse/PFEBMC-2945 Signed-off-by: Vedangi Mittal <vedangimittal3004@gmail.com>
vedangimittal
force-pushed
the
system-parameters
branch
from
badc84d to
2fc1623
Compare
Nikhil-Ashoka
approved these changes
Jul 15, 2024
vedangimittal
added a commit
to vedangimittal/webui-vue
that referenced
this pull request
Nov 13, 2025
- Reduced api calls on System Parameters page - PR Link: ibm-openbmc#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.