Skip to content

Reduced API calls on System Parameters page #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
+40 −134
Merged

Reduced API calls on System Parameters page #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 36 additions & 120 deletions src/store/modules/ResourceManagement/SystemParametersStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import i18n from '@/i18n';
const systemParametersStore = {
namespaced: true,
state: {
registryEntries: [],
rpdPolicyOptions: [],
rpdFeatureOptions: [],
aggressivePrefetch: false,
Expand All @@ -20,6 +21,7 @@ const systemParametersStore = {
rpdScheduledRunDuration: null,
},
getters: {
registryEntries: (state) => state.registryEntries,
aggressivePrefetch: (state) => state.aggressivePrefetch,
frequencyMax: (state) => state.frequencyCap?.frequencyMax,
frequencyMin: (state) => state.frequencyCap?.frequencyMin,
Expand All @@ -41,6 +43,8 @@ const systemParametersStore = {
rpdScheduledRunDuration: (state) => state.rpdScheduledRunDuration,
},
mutations: {
setRegistryEntries: (state, registryEntries) =>
(state.registryEntries = registryEntries),
setFrequencyRequestCurrentToggle: (state, frequencyRequestCurrentToggle) =>
(state.frequencyRequestCurrentToggle = frequencyRequestCurrentToggle),
setAggressivePrefetch: (state, aggressivePrefetch) =>
Expand Down Expand Up @@ -69,138 +73,67 @@ const systemParametersStore = {
(state.rpdScheduledRunDuration = rpdScheduledRunDuration),
},
actions: {
async getAggressivePrefetch({ commit }) {
async getBiosAttributesRegistry({ commit, state }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const aggressivePrefetch = RegistryEntries.Attributes.filter(
.then((response) => {
commit('setRegistryEntries', response.data.RegistryEntries);
const aggressivePrefetch = state.registryEntries.Attributes.filter(
(Attribute) =>
Attribute.AttributeName == 'hb_proc_favor_aggressive_prefetch'
);
let aggressivePrefetchValue = aggressivePrefetch[0].CurrentValue;
let modeValue = aggressivePrefetchValue == 'Enabled' ? true : false;
commit('setAggressivePrefetch', modeValue);
})
.catch((error) => console.log(error));
},
async getRpdPolicy({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdPolicy = RegistryEntries.Attributes.filter(
let aggressivePrefetchModeValue =
aggressivePrefetchValue == 'Enabled' ? true : false;
commit('setAggressivePrefetch', aggressivePrefetchModeValue);
const rpdPolicy = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_policy'
);
let rpdPolicyValue = rpdPolicy[0].CurrentValue;
commit('setRpdPolicy', rpdPolicyValue);
commit('setPvmRpdPolicy', rpdPolicyValue);
})
.catch((error) => console.log(error));
},
async getRpdPolicyCurrent({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdPolicyCurr = RegistryEntries.Attributes.filter(
const rpdPolicyCurr = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_feature_current'
);
let rpdPolicyCurrValue = rpdPolicyCurr[0].CurrentValue;
commit('setRpdPolicyCurrent', rpdPolicyCurrValue);
})
.catch((error) => console.log(error));
},
async getRpdFeature({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdFeature = RegistryEntries.Attributes.filter(
const rpdFeature = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_feature'
);
let rpdFeatureValue = rpdFeature[0].CurrentValue;
commit('setRpdFeature', rpdFeatureValue);
})
.catch((error) => console.log(error));
},
async getImmediateTestRequested({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const immediateTestRequested = RegistryEntries.Attributes.filter(
const immediateTestRequested = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_immediate_test'
);
let immediateTestRequestedValue =
immediateTestRequested[0].CurrentValue;
let modeValue =
let immediateTestRequestedModeValue =
immediateTestRequestedValue == 'Enabled' ? true : false;
commit('setImmediateTestRequested', modeValue);
})
.catch((error) => console.log(error));
},
async getGuardOnError({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const immediateTestRequested = RegistryEntries.Attributes.filter(
commit('setImmediateTestRequested', immediateTestRequestedModeValue);
const guardOnError = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_guard_policy'
);
let immediateTestRequestedValue =
immediateTestRequested[0].CurrentValue;
let modeValue =
immediateTestRequestedValue == 'Enabled' ? true : false;
commit('setGuardOnError', modeValue);
})
.catch((error) => console.log(error));
},
async getRpdPolicyOptions({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdPolicy = RegistryEntries.Attributes.filter(
let guardOnErrorCurr = guardOnError[0].CurrentValue;
let guardOnErrorModeValue =
guardOnErrorCurr == 'Enabled' ? true : false;
commit('setGuardOnError', guardOnErrorModeValue);
const rpdPolicyOps = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_policy'
);
let rpdPolicyOptions = rpdPolicy[0].Value.map(
let rpdPolicyOptions = rpdPolicyOps[0].Value.map(
({ ValueName }) => ValueName
);
commit('setRpdPolicyOptions', rpdPolicyOptions);
})
.catch((error) => console.log(error));
},
async getRpdFeatureOptions({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdPolicy = RegistryEntries.Attributes.filter(
const rpdFeatureOps = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_feature'
);
let rpdFeatureOptions = rpdPolicy[0].Value.map(
let rpdFeatureOptions = rpdFeatureOps[0].Value.map(
({ ValueName }) => ValueName
);
commit('setRpdFeatureOptions', rpdFeatureOptions);
})
.catch((error) => console.log(error));
},
async getRpdScheduledRun({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdScheduledRun = RegistryEntries.Attributes.filter(
const rpdScheduledRun = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'pvm_rpd_scheduled_tod'
);
let RpdScheduledRunValue = rpdScheduledRun[0].CurrentValue;
Expand All @@ -209,21 +142,19 @@ const systemParametersStore = {
const hourString = hours.toString().padStart(2, '0');
const minuteString = minutes.toString().padStart(2, '0');
commit('setRpdScheduledRun', `${hourString}:${minuteString}`);
})
.catch((error) => console.log(error));
},
async getRpdScheduledRunDuration({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const rpdScheduledRunDuration = RegistryEntries.Attributes.filter(
const rpdScheduledRunDuration = state.registryEntries.Attributes.filter(
(Attribute) =>
Attribute.AttributeName == 'pvm_rpd_scheduled_duration'
);
let rpdScheduledRunValue = rpdScheduledRunDuration[0].CurrentValue;
commit('setRpdScheduledRunDuration', rpdScheduledRunValue);
const lateralCastOutMode = state.registryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'hb_lateral_cast_out_mode'
);
let lateralCastOutModeValue = lateralCastOutMode[0].CurrentValue;
let lateralCastModeValue =
lateralCastOutModeValue == 'Enabled' ? true : false;
commit('setLateralCastOutMode', lateralCastModeValue);
})
.catch((error) => console.log(error));
},
Expand Down Expand Up @@ -265,7 +196,7 @@ const systemParametersStore = {
'setRpdPolicy',
updatedRpdPolicyValue.Attributes.pvm_rpd_policy
);
dispatch('getRpdPolicy');
dispatch('getBiosAttributesRegistry');
return i18n.t('pageSystemParameters.toast.successSavingRpdPolicy');
})
.catch((error) => {
Expand Down Expand Up @@ -387,21 +318,6 @@ const systemParametersStore = {
);
});
},
async getLateralCastOutMode({ commit }) {
return await api
.get(
'/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'
)
.then(({ data: { RegistryEntries } }) => {
const lateralCastOutMode = RegistryEntries.Attributes.filter(
(Attribute) => Attribute.AttributeName == 'hb_lateral_cast_out_mode'
);
let lateralCastOutModeValue = lateralCastOutMode[0].CurrentValue;
let modeValue = lateralCastOutModeValue == 'Enabled' ? true : false;
commit('setLateralCastOutMode', modeValue);
})
.catch((error) => console.log(error));
},
async saveLateralCastOutMode({ commit }, lateralCastOutModeValue) {
let updatedModeValue = lateralCastOutModeValue ? 'Enabled' : 'Disabled';
commit('setLateralCastOutMode', lateralCastOutModeValue);
Expand Down
2 changes: 1 addition & 1 deletion src/views/ResourceManagement/SystemParameters/RuntimeProcessorDiagnostic.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export default {
this.$store.dispatch('systemParameters/saveImmediateTestRequested', {
value: value ? 'Enabled' : 'Disabled',
}),
this.$store.dispatch('systemParameters/getRpdScheduledRun'),
this.$store.dispatch('systemParameters/getBiosAttributesRegistry'),
])
.then((message) => {
if (value && this.isServerOff) {
Expand Down
16 changes: 3 additions & 13 deletions src/views/ResourceManagement/SystemParameters/SystemParameters.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,9 @@ export default {
},
created() {
this.startLoader();
Promise.all([
this.$store.dispatch('systemParameters/getLateralCastOutMode'),
this.$store.dispatch('systemParameters/getAggressivePrefetch'),
this.$store.dispatch('systemParameters/getImmediateTestRequested'),
this.$store.dispatch('systemParameters/getGuardOnError'),
this.$store.dispatch('systemParameters/getRpdPolicyOptions'),
this.$store.dispatch('systemParameters/getRpdFeatureOptions'),
this.$store.dispatch('systemParameters/getRpdPolicy'),
this.$store.dispatch('systemParameters/getRpdPolicyCurrent'),
this.$store.dispatch('systemParameters/getRpdFeature'),
this.$store.dispatch('systemParameters/getRpdScheduledRun'),
this.$store.dispatch('systemParameters/getRpdScheduledRunDuration'),
]).finally(() => this.endLoader());
this.$store
.dispatch('systemParameters/getBiosAttributesRegistry')
.finally(() => this.endLoader());
},
};
</script>